Skip to content

HIVE-29145: HMS Iceberg REST fails on common HMS #6156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
+0 −18
Merged

HIVE-29145: HMS Iceberg REST fails on common HMS #6156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions ...store/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@

package org.apache.iceberg.rest;

import com.codahale.metrics.Counter;
import com.google.common.base.Preconditions;
import org.apache.hadoop.hive.metastore.metrics.Metrics;
import java.util.Arrays;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -80,8 +78,6 @@
* Adaptor class to translate REST requests into {@link Catalog} API calls.
*/
public class HMSCatalogAdapter implements RESTClient {
/** The metric names prefix. */
static final String HMS_METRIC_PREFIX = "hmscatalog.";
private static final Splitter SLASH = Splitter.on('/');

private static final Map<Class<? extends Exception>, Integer> EXCEPTION_ERROR_CODES =
Expand Down Expand Up @@ -214,14 +210,6 @@ public Class<? extends RESTRequest> requestClass() {
}
}

/**
* @param route a route/api-call name
* @return the metric counter name for the api-call
*/
static String hmsCatalogMetricCount(String route) {
return HMS_METRIC_PREFIX + route.toLowerCase() + ".count";
}

private ConfigResponse config() {
final List<Endpoint> endpoints = Arrays.stream(Route.values())
.map(r -> Endpoint.create(r.method.name(), r.resourcePath)).toList();
Expand Down Expand Up @@ -421,12 +409,6 @@ private static void commitTransaction(Catalog catalog, CommitTransactionRequest
@SuppressWarnings({"MethodLength", "unchecked"})
private <T extends RESTResponse> T handleRequest(
Route route, Map<String, String> vars, Object body) {
// update HMS catalog route counter metric
final String metricName = hmsCatalogMetricCount(route.name());
Counter counter = Metrics.getOrCreateCounter(metricName);
if (counter != null) {
counter.inc();
}
switch (route) {
case CONFIG:
return (T) config();
Expand Down