Fix PublicSuffixMatcherLoader#getDefault #621
Merged
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since is the being resolved via Class#getResource, the path to the file in question is absolute, not relative.
|
@joegallo That you for contributing this fix. |
ok2c
pushed a commit
that referenced
this pull request
Mar 6, 2025
|
Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code of
getDefaultreads like it's supposed to load the entries fromPUBLIC_SUFFIX_LISTby default, but it doesn't actually work that way in practice. I think this is a bug. This works correctly on 4.x, but the list there already starts with a leading slash:httpcomponents-client/httpclient/src/main/java/org/apache/http/conn/util/PublicSuffixMatcherLoader.java
Line 86 in 54900db
This was sneaking past the tests, because the test for getDefault only checks that it isn't
null, but a non-null nearly empty default PublicSuffixMatcher is still provided in the case of the url not existing, and the tests for PublicSuffixMatcher themselves reimplement the default loading logic (correctly, since they rely onClassLoader#getResourcerather thanClass#getResource) and so they weren't running into the bug either.