fix: incorrectly added statement could cause deadlock#1306
Closed
sdd wants to merge 1 commit intoapache:mainfrom
Closed
fix: incorrectly added statement could cause deadlock#1306sdd wants to merge 1 commit intoapache:mainfrom
sdd wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
@liurenjie1024 @Xuanwo: please review this tiny bug fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
awaitstatement could cause deadlock at some point #1305.What changes are included in this PR?
Remove incorrect
await.Are these changes tested?
All existing tests pass. Integ test that reads positional deletes in #1011 no longer deadlocks with this fix.