Rest: Implement register table#1521
Merged
liurenjie1024 merged 2 commits intoapache:mainfrom Jul 31, 2025
Merged
Conversation
gabeiglio
force-pushed
the
rest-register-table
branch
from
0bfda56 to
5c342f3
Compare
gabeiglio
commented
Jul 17, 2025
gabeiglio
commented
Jul 17, 2025
gabeiglio
force-pushed
the
rest-register-table
branch
from
5c342f3 to
574069f
Compare
5 tasks
CTTY
reviewed
Jul 22, 2025
Collaborator
CTTY
left a comment
CTTY
left a comment
There was a problem hiding this comment.
Hi @gabeiglio , thanks for your contribution! I've left some suggestions
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @gabeiglio for this pr, generally LGTM! Left some comments to fix.
gabeiglio
force-pushed
the
rest-register-table
branch
from
574069f to
de387fc
Compare
gabeiglio
commented
Jul 28, 2025
gabeiglio
force-pushed
the
rest-register-table
branch
from
de387fc to
064c927
Compare
liurenjie1024
approved these changes
Jul 31, 2025
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @gabeiglio for this pr!
Yiyang-C
pushed a commit
to Yiyang-C/iceberg-rust
that referenced
this pull request
Aug 26, 2025
## Which issue does this PR close? - Closes apache#1516. ## What changes are included in this PR? - New type for RegisterTableRequest - New method in rest catalog for implementing register table ## Are these changes tested? - 2 unit tests for a successful registered table operation and a failed one due to namespace is non existent - Integration tests for a successful registered table operation Im new to Rust so any feedback is welcomed! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?
Im new to Rust so any feedback is welcomed! :)