Skip to content

feat(reader): support timestamp type in create_column#2180

Merged
blackmwk merged 1 commit intoapache:mainfrom
chenzl25:dylan/fix_record_batch_transform_timestamp_type
Mar 10, 2026
Merged

feat(reader): support timestamp type in create_column#2180
blackmwk merged 1 commit intoapache:mainfrom
chenzl25:dylan/fix_record_batch_transform_timestamp_type

Conversation

@chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Feb 26, 2026

Which issue does this PR close?

Similar to #1847

  • Closes #.

What changes are included in this PR?

  • RecordBatchTransformer does not support timestamp type. This PR adds logic to create_column in the specific scenario for a schema evolution with a new timestamp column.

Are these changes tested?

2 unit tests test_create_timestamp_microsecond_with_timezone_array_repeated and test_create_timestamp_microsecond_array_repeated are added.

Copy link
Collaborator

@CTTY CTTY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@blackmwk blackmwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chenzl25 for this pr!

@blackmwk blackmwk merged commit d65d008 into apache:main Mar 10, 2026
19 checks passed
gbrgr pushed a commit to RelationalAI/iceberg-rust that referenced this pull request Mar 10, 2026
## Which issue does this PR close?

Similar to apache#1847

- Closes #.

## What changes are included in this PR?

- RecordBatchTransformer does not support timestamp type. This PR adds
logic to create_column in the specific scenario for a schema evolution
with a new timestamp column.

## Are these changes tested?

<!--
Specify what test covers (unit test, integration test, etc.).

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

2 unit tests
test_create_timestamp_microsecond_with_timezone_array_repeated and
test_create_timestamp_microsecond_array_repeated are added.
gbrgr added a commit to RelationalAI/iceberg-rust that referenced this pull request Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants