Skip to content

chore: Update MSRV to 1.91.0 #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blackmwk merged 1 commit into from
Mar 5, 2026
Merged

chore: Update MSRV to 1.91.0 #2204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ version = "0.8.0"
license = "Apache-2.0"
repository = "https://github.com/apache/iceberg-rust"
# Check the MSRV policy in README.md before changing this
rust-version = "1.88"
rust-version = "1.91"

[workspace.dependencies]
anyhow = "1.0.72"
Expand Down
2 changes: 1 addition & 1 deletion bindings/python/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
edition = "2024"
homepage = "https://rust.iceberg.apache.org"
name = "pyiceberg_core_rust"
rust-version = "1.88"
rust-version = "1.91"
version = "0.8.0"
# This crate is used to build python bindings, we don't want to publish it
publish = false
Expand Down
9 changes: 2 additions & 7 deletions crates/iceberg/src/spec/snapshot.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,12 @@ pub const UNASSIGNED_SNAPSHOT_ID: i64 = -1;

/// Reference to [`Snapshot`].
pub type SnapshotRef = Arc<Snapshot>;
#[derive(Debug, Serialize, Deserialize, PartialEq, Eq, Clone)]
#[derive(Debug, Default, Serialize, Deserialize, PartialEq, Eq, Clone)]
#[serde(rename_all = "lowercase")]
/// The operation field is used by some operations, like snapshot expiration, to skip processing certain snapshots.
pub enum Operation {
/// Only data files were added and no files were removed.
#[default]
Append,
/// Data and delete files were added and removed without changing table data;
/// i.e., compaction, changing the data file format, or relocating data files.
Expand Down Expand Up @@ -75,12 +76,6 @@ pub struct Summary {
pub additional_properties: HashMap<String, String>,
}

impl Default for Operation {
fn default() -> Operation {
Self::Append
}
}

#[derive(Debug, PartialEq, Eq, Clone)]
/// Row range of a snapshot, contains first_row_id and added_rows_count.
pub struct SnapshotRowRange {
Expand Down
2 changes: 1 addition & 1 deletion crates/integrations/datafusion/src/physical_plan/scan.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ impl ExecutionPlan for IcebergTableScan {
self
}

fn children(&self) -> Vec<&Arc<(dyn ExecutionPlan + 'static)>> {
fn children(&self) -> Vec<&Arc<dyn ExecutionPlan + 'static>> {
vec![]
}

Expand Down
2 changes: 1 addition & 1 deletion rust-toolchain.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@
#
# The channel is exactly same day for our MSRV.
[toolchain]
channel = "nightly-2025-06-23"
channel = "nightly-2025-10-27"
components = ["rustfmt", "clippy"]
Loading