feat(iceberg): Add snapshot utils to scan ancestors#2285
Open
CTTY wants to merge 2 commits intoapache:mainfrom
Open
feat(iceberg): Add snapshot utils to scan ancestors#2285CTTY wants to merge 2 commits intoapache:mainfrom
CTTY wants to merge 2 commits intoapache:mainfrom
Conversation
blackmwk
reviewed
Mar 25, 2026
| } | ||
|
|
||
| /// Iterate starting from `snapshot` (inclusive) to the root snapshot. | ||
| pub fn ancestors_of( |
Contributor
There was a problem hiding this comment.
Why not make this part of TableMetadata?
| pub fn ancestors_of( | ||
| table_metadata: &TableMetadataRef, | ||
| snapshot: i64, | ||
| ) -> Box<dyn Iterator<Item = SnapshotRef> + Send> { |
Contributor
There was a problem hiding this comment.
I don't think we need a Box here, you can make your iterator return None directly.
| } | ||
|
|
||
| /// Iterate starting from `snapshot` (inclusive) to `oldest_snapshot_id` (exclusive). | ||
| pub fn ancestors_between( |
Contributor
There was a problem hiding this comment.
It should be put into Ancestors struct.
|
|
||
| use crate::spec::{SnapshotRef, TableMetadataRef}; | ||
|
|
||
| struct Ancestors { |
Contributor
There was a problem hiding this comment.
Since we may have more conditions to build iterator, it's more idiomatic to implement IntoIterator for Ancestors, rather than Iterator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Ancestorsto help scan past snapshotsAre these changes tested?
Yes