-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display boundaries and borders #928
Comments
This issue looks interesting. I’d like to resolve the issue below and start working on it right away. |
Great, I left a comment in the other PR. Do not hesitate to reach out if you have difficulties entering the code for the basemap or the java code. |
Can I ask which part of the Java code is handling the multi-polygons? |
Sure, here is the class that créâtes the multiplepolygons: Line 41 in 96cf335
|
The most important test for osm data is located here: Line 49 in 96cf335
It uses the examples and corner cases listed in: |
Thank you! I’ll start working on it after I get off work. 😊 |
Description: Openstreetmap contains tags for boundaries and borders and we should properly display them at low and high zoom levels. We currently display borders at level 13 and greater. This change probably requires to do some line work and simplifications in the database and possibly in the java code as well (for handling complex multipolygons).
Tag:
https://wiki.openstreetmap.org/wiki/Key:boundary
Attachements:
![Image](https://private-user-images.githubusercontent.com/238747/408458243-6b741b0a-588e-4ef1-9597-da601f3d9e41.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NzkxNzAsIm5iZiI6MTczOTY3ODg3MCwicGF0aCI6Ii8yMzg3NDcvNDA4NDU4MjQzLTZiNzQxYjBhLTU4OGUtNGVmMS05NTk3LWRhNjAxZjNkOWU0MS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNlQwNDA3NTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wNjE1MzhkODdhYWNhZThiODVlZTJkZGI2ODY3NjQzYWZmNzBhNjM5YmI3N2NjZWQxMzVjZjhkOWM2ZGRmN2FjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.yuzjYOImkRML6xrPwAAlM_jNTzwdc9HkrqemIB9D0uA)
Files:
https://github.com/apache/incubator-baremaps/tree/main/basemap/layers/boundary
The text was updated successfully, but these errors were encountered: