Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display boundaries and borders #928

Open
bchapuis opened this issue Jan 31, 2025 · 6 comments · May be fixed by #948
Open

Display boundaries and borders #928

bchapuis opened this issue Jan 31, 2025 · 6 comments · May be fixed by #948
Labels
basemap good first issue Good for newcomers

Comments

@bchapuis
Copy link
Member

bchapuis commented Jan 31, 2025

Description: Openstreetmap contains tags for boundaries and borders and we should properly display them at low and high zoom levels. We currently display borders at level 13 and greater. This change probably requires to do some line work and simplifications in the database and possibly in the java code as well (for handling complex multipolygons).

Tag:
https://wiki.openstreetmap.org/wiki/Key:boundary

Attachements:
Image

Files:
https://github.com/apache/incubator-baremaps/tree/main/basemap/layers/boundary

@bchapuis bchapuis added good first issue Good for newcomers basemap labels Jan 31, 2025
@YongGoose
Copy link
Contributor

@bchapuis

This issue looks interesting.
Would it be okay if I take it on?

I’d like to resolve the issue below and start working on it right away.

@bchapuis
Copy link
Member Author

Great, I left a comment in the other PR. Do not hesitate to reach out if you have difficulties entering the code for the basemap or the java code.

@YongGoose
Copy link
Contributor

@bchapuis

Can I ask which part of the Java code is handling the multi-polygons?

@bchapuis
Copy link
Member Author

bchapuis commented Feb 5, 2025

Sure, here is the class that créâtes the multiplepolygons:

@bchapuis
Copy link
Member Author

bchapuis commented Feb 5, 2025

The most important test for osm data is located here:

It uses the examples and corner cases listed in:
https://osmcode.org/osm-testdata/

@YongGoose
Copy link
Contributor

@bchapuis

Thank you! I’ll start working on it after I get off work. 😊

@YongGoose YongGoose linked a pull request Feb 8, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
basemap good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants