Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the NOTICE file for the binary distribution #940

Merged
merged 7 commits into from
Feb 2, 2025
Merged

Conversation

bchapuis
Copy link
Member

@bchapuis bchapuis commented Feb 1, 2025

Following the discussion on JIRA regarding the NOTICE file for the binary distribution, this PR removes the notices-binary directory and concat all the notices in a single NOTICE-BINARY file at the root of the project. This file is renamed NOTICE and placed at the root of the binary distribution with maven assembly.

Copy link

sonarqubecloud bot commented Feb 1, 2025

@bchapuis bchapuis requested a review from CalvinKirs February 1, 2025 00:02
@bchapuis
Copy link
Member Author

bchapuis commented Feb 1, 2025

@CalvinKirs I hope you are doing well. Do these changes suits you to address the licensing concerns raised in rc2? Thanks for your help.

@bchapuis
Copy link
Member Author

bchapuis commented Feb 1, 2025

@CalvinKirs For the source distribution, cleaning up the NOTICE files and keeping only the meaningful parts is realistic, as we have a good understanding of the source code. However, doing the same for the binary distribution and its dependencies is much more challenging since it's difficult to control what actually goes into the JAR files. I'm concerned that removing something important could have legal implications. To be safe, I decided to concatenate all the NOTICE files for the binary distribution.

@bchapuis bchapuis merged commit 6cae7e0 into main Feb 2, 2025
10 checks passed
@bchapuis bchapuis deleted the notice-binary branch February 2, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants