[GLUTEN-1874][CH] Fixes nullable mismatch in union #1901
Conversation
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
@jinchengchenghh @rui-mo Do you have any more questions? |
|
There are some conflicts need to be resolved. |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
| return childCtx | ||
| // Since some columns' nullability will be removed after this filter, we need to update the | ||
| // outputAttributes of child context. | ||
| TransformContext(childCtx.inputAttributes, output, childCtx.root) |
There was a problem hiding this comment.
maybe can not return the output of the filter when all the filter are pushdowned, some attrs may be removed in this case. @rui-mo
There was a problem hiding this comment.
In this case, this fiter is no sense.
There was a problem hiding this comment.
In Velox backend, if all the conditions are pushed down, the filter's computing is ignored.
gluten-core/src/main/scala/io/glutenproject/backendsapi/BackendSettingsApi.scala
Outdated
Show resolved
Hide resolved
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Fixes: #1874
main changes
add a new field
output_schemainRelRootThis field will not affect
veloxadd a nullable projections after parsing root node in
CHnew implementation for finding the non-nullable columns
This has the largest changes, since we remove all the
required_columnsin many functionsfixed some bugs about pushing down filter in merge tree
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
unit tests
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)