[fixed] fixed envsetting unload flink-conf.yaml,if not like catalogstore conf will not work #4108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore conf will not work
|
wolfboys
reviewed
Oct 7, 2024
| case null | "" => | ||
| throw new ExceptionInInitializerError( | ||
| "[StreamPark] Usage:can't find config,please set \"--flink.conf $conf \" in main arguments") | ||
| case conf => builder.withConfiguration(Configuration.fromMap(PropertiesUtils.fromYamlText(DeflaterUtils.unzipString(conf)))) |
There was a problem hiding this comment.
Thanks for your contribution, but the method builder.withConfiguration has compatibility issues
|
I reviewed the code implementation for this section and did not identify any issues. We may need to confirm whether this problem actually occurs. Additionally, I provided feedback on this PR, noting some compatibility issues. Since this PR has been pending for a long time, I will go ahead and close it. If you believe the problem exists, feel free to submit a new PR to address it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request
Issue Number: close #4107
Brief change log
fixed envsetting unload flink-conf.yaml,if not like catalogstore conf will not work
Does this pull request potentially affect one of the following parts