Support discussions #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netomi
force-pushed
the
support-discussions
branch
from
4de26c1 to
0cb31cd
Compare
|
The overall suggestion looks good, I'll let @cottage14 take a gander at the wording and then merge. |
Humbedooh
approved these changes
Feb 20, 2025
cottage14
requested changes
Feb 20, 2025
There was a problem hiding this comment.
for
- NOTE: When enabling discussions, a valid notification target for discussions must be specified.
I suggest
NOTE: When enabling discussions, you must specify a valid notification target for discussions.
|
ty for the suggestion, it reads much better like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #19 .
Repository discussions was already supported, but the README was not reflecting the current state.
Updated the relevant sections and removed the note about being a beta feature that is not supported yet.