Skip to content

Add TableFunctionHandle for TVF #15394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 26, 2025
Merged

Add TableFunctionHandle for TVF #15394

merged 6 commits into from
Apr 26, 2025

Conversation

Cpaulyz
Copy link
Contributor

@Cpaulyz Cpaulyz commented Apr 22, 2025

Description

Add TableFunctionHandle for TVF

Copy link

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 75 lines in your changes missing coverage. Please review.

Project coverage is 39.36%. Comparing base (aa1bd05) to head (5592122).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...lan/relational/planner/node/TableFunctionNode.java 20.00% 12 Missing ⚠️
.../builtin/relational/tvf/CumulateTableFunction.java 0.00% 12 Missing ⚠️
...df/builtin/relational/tvf/TumbleTableFunction.java 0.00% 11 Missing ⚠️
...ional/planner/node/TableFunctionProcessorNode.java 27.27% 8 Missing ⚠️
.../builtin/relational/tvf/CapacityTableFunction.java 0.00% 8 Missing ⚠️
...f/builtin/relational/tvf/SessionTableFunction.java 0.00% 8 Missing ⚠️
...builtin/relational/tvf/VariationTableFunction.java 0.00% 8 Missing ⚠️
...s/udf/builtin/relational/tvf/HOPTableFunction.java 64.28% 5 Missing ⚠️
...eryengine/plan/planner/TableOperatorGenerator.java 0.00% 1 Missing ⚠️
...ngine/plan/planner/plan/node/PlanGraphPrinter.java 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15394      +/-   ##
============================================
- Coverage     39.42%   39.36%   -0.06%     
- Complexity      193      198       +5     
============================================
  Files          4648     4653       +5     
  Lines        300357   300823     +466     
  Branches      37519    37600      +81     
============================================
+ Hits         118409   118434      +25     
- Misses       181948   182389     +441     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@JackieTien97 JackieTien97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still need to think about how to remove arguments from Node

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@JackieTien97 JackieTien97 merged commit db3a384 into master Apr 26, 2025
50 of 53 checks passed
@JackieTien97 JackieTien97 deleted the tvf_handler branch April 26, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants