pref: Adjustments to sbin and tools Scripts #15402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
CritasWang
commented
Apr 24, 2025
CritasWang
commented
- Script Central Management: Migrate scripts scattered across different projects to the scripts/sbin and scripts/tools directories under the root directory.
- Script Functional Classification: Categorize and move scripts to different files or subdirectories based on their functionality. For frequently used scripts, their current locations will be preserved to minimize the impact on existing workflows.
- Create a Windows subfolder under the sbin directory (sbin, sbin/windows).
1. Script Central Management: Migrate scripts scattered across different projects to the scripts/sbin and scripts/tools directories under the root directory. 2. Script Functional Classification: Categorize and move scripts to different files or subdirectories based on their functionality. For frequently used scripts, their current locations will be preserved to minimize the impact on existing workflows. 3. Create a Windows subfolder under the sbin directory (sbin, sbin/windows).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15402 +/- ##
============================================
- Coverage 39.36% 39.35% -0.01%
Complexity 198 198
============================================
Files 4653 4653
Lines 300823 300823
Branches 37600 37600
============================================
- Hits 118420 118391 -29
- Misses 182403 182432 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes and reorganizes script resources by moving them to the new scripts/sbin and scripts/tools directories and introduces a Windows subfolder for platform-specific scripts. Key changes include:
- Updating file paths in test cases to reflect the new Windows subdirectory structure.
- Bumping the AINode version in the pyproject.toml.
- Adjusting script locations for import, export, and client startup scripts across multiple integration tests.
Reviewed Changes
Copilot reviewed 82 out of 93 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| iotdb-core/datanode/src/test/java/org/apache/iotdb/db/script/EnvScriptIT.java | Updates Windows script path for datanode-env.bat in tests |
| iotdb-core/ainode/pyproject.toml | Bumps AINode version from 2.0.0.dev to 2.0.4.dev |
| integration-test/src/test/java/org/apache/iotdb/tools/it/ImportSchemaTestIT.java | Updates Windows script path for import-schema tests |
| integration-test/src/test/java/org/apache/iotdb/tools/it/ImportDataTestIT.java | Updates Windows script path for import-data tests |
| integration-test/src/test/java/org/apache/iotdb/tools/it/ExportTsFileTestIT.java | Updates Windows script path for export-tsfile tests |
| integration-test/src/test/java/org/apache/iotdb/tools/it/ExportSchemaTestIT.java | Updates Windows script path for export-schema tests |
| integration-test/src/test/java/org/apache/iotdb/tools/it/ExportDataTestIT.java | Updates Windows script path for export-data tests |
| integration-test/src/test/java/org/apache/iotdb/cli/it/StartClientScriptIT.java | Updates Windows script path for start-cli tests |
Files not reviewed (11)
- distribution/src/assembly/ainode.xml: Language not supported
- distribution/src/assembly/all.xml: Language not supported
- distribution/src/assembly/cli.xml: Language not supported
- distribution/src/assembly/confignode.xml: Language not supported
- distribution/src/assembly/datanode.xml: Language not supported
- integration-test/src/assembly/mpp-test.xml: Language not supported
- iotdb-client/cli/src/assembly/cli.xml: Language not supported
- iotdb-core/ainode/ainode.xml: Language not supported
- iotdb-core/confignode/src/assembly/confignode.xml: Language not supported
- iotdb-core/datanode/src/assembly/server.xml: Language not supported
- library-udf/src/assembly/tools/register-UDF.bat: Language not supported
HTHou
approved these changes
Apr 25, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.