Repository navigation
Fix SingleDeviceViewOperatorTest row assertion - #17995
Merged
jt2594838 merged 1 commit intoJun 22, 2026
Merged
Conversation
jt2594838
approved these changes
Jun 22, 2026
jt2594838
pushed a commit
that referenced
this pull request
Jun 23, 2026
MileaRobertStefan
pushed a commit
to MileaRobertStefan/iotdb
that referenced
this pull request
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a fragile assertion in SingleDeviceViewOperatorTest. The test used to derive the expected timestamp from the TsBlock index and assumed each returned block contains 20 rows. The operator contract does not guarantee that block size, so when the child operator returns a larger block, the expected timestamp resets incorrectly and the test can fail with expected 20 but was 320.
The test now validates timestamps by a global row counter across all returned TsBlocks, while preserving the existing value and null-column checks.
This is unrelated to the show receivers changes: the current show-receivers branch does not modify SingleDeviceViewOperatorTest, SingleDeviceViewOperator, FullOuterTimeJoinOperator, or SeriesReaderTestUtil.
Tests