Repository navigation
Reclaim the statement variable to avoid executing stale statements in the subsequent new test case - #18001
Merged
Conversation
… the subsequent new test case.
HTHou
reviewed
Jun 22, 2026
HTHou
left a comment
HTHou
left a comment
Contributor
There was a problem hiding this comment.
One cleanup concern in integration-test/src/test/java/org/apache/iotdb/db/it/utils/TestUtils.java around line 1212:
Statement.close() can itself throw SQLException. Since it now runs before localConnection.close() in the same try, a close failure here would skip closing the local connection and can leak it on the retry path. Could you split the statement and connection closes into separate try/catch blocks, or otherwise ensure localConnection.close() is still attempted even when closing the statement fails?
HTHou
approved these changes
Jun 22, 2026
MileaRobertStefan
pushed a commit
to MileaRobertStefan/iotdb
that referenced
this pull request
Jun 26, 2026
… the subsequent new test case (apache#18001) * Reclaim the statement variable to avoid executing stale statements in the subsequent new test case. * Don't affect the connection closing any more * Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.