Repository navigation
Conversation
Serialize poll limit checks with event claims, count retained and lingering events throughout consensus prefetch, and honor topic recycle settings when capacity is full. Preserve bounded realtime admission and add regression coverage for the reproduced failures.
Collaborator
Author
|
Self-review passed after fixes in 9589f42. All actionable findings from this review have been resolved. Fixed findings:
Also removed the two newly introduced untranslated debug message literals. Added regression coverage for pending/WAL/multi-writer delivery, ack/ackSilent recovery, retained capacity, and topic recycle overrides. Validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ack/ackSilentfrees a retained-event slot, so queues resume promptly after backpressure clears.SubscriptionPrefetchingQueueStatesfor focused unit coverage of global threshold calculations without bootstrapping the global subscription broker.Motivation
Previously, the main limits primarily looked at prefetched queue size. If a consumer kept polling but did not commit, events moved into the in-flight map and no longer counted against those prefetch limits. That could allow retained subscription events to accumulate and delay backpressure until memory pressure or other secondary limits were hit. This PR makes in-flight events part of the capacity model and throttles further polling when the in-flight side itself reaches the configured limits.
Testing
mvn spotless:apply -pl iotdb-core/datanodegit diff --check origin/master...HEADmvn -Ddevelocity.off=true -pl iotdb-core/datanode -Dtest=SubscriptionPrefetchingQueueStatesTest -DforkCount=0 testSubscriptionPrefetchingQueueStatesTest.forkCount=0was used only for this local Windows environment because the default Surefire fork JVM failed to start due to insufficient page file / native memory before any tests ran.