Repository navigation
Conversation
jt2594838
approved these changes
Sep 29, 2026
Caideyipi
approved these changes
Sep 29, 2026
Caideyipi
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the current head. No code issues found. The PR description still says the tests cover prepared statements, but that test was removed in the latest commit; please update the description to match the final diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix table
INSERTstatements that use unsupported time expressions. They now return a semantic error instead of exposing aClassCastException. Validtimestamps and
NULLkeep their existing behavior.The parser now uses the existing
AstUtil.expressionToTimestampmethod, so both insert paths apply the same validation. Integration tests cover supportedvalues, unsupported expressions, and prepared statements.
Validation: Spotless passed; Maven
test-compilepassed for all 39 modules. Integration tests were added but not run.This PR has:
Key changed/added classes
AstBuilder: delegates timestamp conversion toAstUtil.IoTDBInsertTableIT: covers supported and unsupported time values.IoTDBTablePreparedStatementIT: covers rejected time parameters.