Repository navigation
Conversation
jt2594838
reviewed
Oct 10, 2026
jt2594838
left a comment
Contributor
There was a problem hiding this comment.
May push the implementation directly into ReadWriteIOUtils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validate length-prefixed Pipe strings and binary payloads against the remaining request body before decoding V1/V2 handshakes, slices, and receiver-runtime cleanup requests. Also reject V2 handshake parameter counts that cannot fit in the body. Malformed payloads now return the existing
PIPE_ERRORresponse, including through compressed wrappers.Valid wire encoding, null/empty strings, and handshake buffer positions remain compatible.
Validation
PipeTransferRequestValidationTest,PipeTransferSliceReqBuilderTest,PipeTransferCompressedReqTest,PipeDataNodeThriftRequestTest, andPipeReceiverTest.MAVEN_OPTS=-Xmx2g.This PR has:
Key changed/added classes
PipeTransferPayloadReader,PipeTransferHandshakeV1Req,PipeTransferHandshakeV2Req,PipeTransferSliceReq, andPipeTransferPipeReceiverRuntimeInfoCleanupReq.