KAFKA-17374: add bootstrap.controller to kafka-reassign-partitions.sh #16964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this PR should wait for PR |
chia7712
reviewed
Aug 31, 2024
| @@ -83,6 +84,13 @@ public ReassignPartitionsCommandOptions(String[] args) { | |||
| .withRequiredArg() | |||
| .describedAs("brokerlist") | |||
| .ofType(String.class); | |||
|
|
|||
| bootstrapControllerOpt = parser.accepts("bootstrap-controller", "The controller to use for reassignment. " + | |||
| "By default, the tool will get the controller from the broker.") | |||
There was a problem hiding this comment.
the tool will get the controller from the broke this description is not correct. The controller is "quorum controller" rather than "broker controller"
| @@ -29,7 +29,7 @@ | |||
|
|
|||
| @Timeout(60) | |||
| public class ReassignPartitionsCommandArgsTest { | |||
| public static final String MISSING_BOOTSTRAP_SERVER_MSG = "Please specify --bootstrap-server"; | |||
| public static final String MISSING_BOOTSTRAP_SERVER_MSG = "Please specify either --bootstrap-server"; | |||
There was a problem hiding this comment.
I change the error message in validate method, thus these error message should be changed
if (opts.options.has(opts.bootstrapServerOpt) && opts.options.has(opts.bootstrapControllerOpt))
CommandLineUtils.printUsageAndExit(opts.parser, "Please don't specify both --bootstrap-server and --bootstrap-controller");
else if (!opts.options.has(opts.bootstrapServerOpt) && !opts.options.has(opts.bootstrapControllerOpt))
CommandLineUtils.printUsageAndExit(opts.parser, "Please specify either --bootstrap-server or --bootstrap-controller");
else
bootstrapOpt = opts.options.has(opts.bootstrapServerOpt) ? opts.bootstrapServerOpt : opts.bootstrapControllerOpt;
chia7712
reviewed
Sep 15, 2024
| private static void validateBootstrapControllerNotSupportedAction(ReassignPartitionsCommandOptions opts) { | ||
| if (opts.options.has(opts.bootstrapControllerOpt)) { | ||
| if (opts.options.has(opts.verifyOpt) || opts.options.has(opts.executeOpt) || opts.options.has(opts.generateOpt)) { | ||
| throw new UnsupportedOperationException("The --bootstrap-controller option is not supported with these action."); |
There was a problem hiding this comment.
Could you please add the unsupported actions to the comment?
| @@ -83,6 +84,13 @@ public ReassignPartitionsCommandOptions(String[] args) { | |||
| .withRequiredArg() | |||
| .describedAs("brokerlist") | |||
| .ofType(String.class); | |||
|
|
|||
| bootstrapControllerOpt = parser.accepts("bootstrap-controller", "The controller to use for reassignment. " + | |||
| "By default, the tool will get the quorum controller.") | |||
There was a problem hiding this comment.
Please add the supported actions to the docs
| @@ -129,7 +129,12 @@ public static void main(String[] args) { | |||
| Properties props = opts.options.has(opts.commandConfigOpt) | |||
| ? Utils.loadProps(opts.options.valueOf(opts.commandConfigOpt)) | |||
| : new Properties(); | |||
| props.put(AdminClientConfig.BOOTSTRAP_SERVERS_CONFIG, opts.options.valueOf(opts.bootstrapServerOpt)); | |||
| validateBootstrapControllerNotSupportedAction(opts); | |||
There was a problem hiding this comment.
Could you please move this to validateAndParseArgs?
|
@m1a2st could you please sync code? |
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
…pache#16964) Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: issues.apache.org/jira/browse/KAFKA-17374
According to the KIP-919
kafka-reassign-partitions.shshould support the--bootstrap-controllerargument.Committer Checklist (excluded from commit message)