KAFKA-17526: make ConfigCommandIntegrationTest.java test use correct arguments in testing alias #17201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arguments in testing alias
chia7712
reviewed
Sep 24, 2024
| @@ -324,11 +324,13 @@ public void testDynamicBrokerConfigUpdateUsingKraft() throws Exception { | |||
|
|
|||
| @ClusterTest(types = {Type.KRAFT, Type.CO_KRAFT}) | |||
| public void testGroupConfigUpdateUsingKraft() throws Exception { | |||
| alterOpts = asList("--bootstrap-server", cluster.bootstrapServers(), "--entity-type", "groups", "--alter"); | |||
| alterOpts = Stream.concat(entityOp(Optional.of(defaultGroupName)).stream(), | |||
There was a problem hiding this comment.
Can we make alterOpts a local variable? it is a bit chaos that alterOpts can be modified by any method.
github-actions
bot
added
core
|
@frankvicky Could you please rebase code to include recent fix? |
|
@frankvicky please fix the conflicts |
|
Hi @chia7712 |
chia7712
approved these changes
Oct 22, 2024
abhishekgiri23
pushed a commit
to abhishekgiri23/kafka
that referenced
this pull request
Nov 2, 2024
…rguments in testing alias (apache#17201) Reviewers: Chia-Ping Tsai <[email protected]>
chiacyu
pushed a commit
to chiacyu/kafka
that referenced
this pull request
Nov 30, 2024
…rguments in testing alias (apache#17201) Reviewers: Chia-Ping Tsai <[email protected]>
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
…rguments in testing alias (apache#17201) Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: KAFKA-17526
This PR reviews existing tests and refactors the validation to ensure the command is generated correctly.
Committer Checklist (excluded from commit message)