MINOR Don't run tests for Draft PRs #17299
Conversation
|
Example of the tests and build scans being skipped (from my fork): 
When I click "Ready For Review", the CI kicks off and the tests run Screen.Recording.2024-09-27.at.10.11.03.AM.mov |
mumrah
changed the title
|
Example with "WIP" in title: mumrah#25 |
.github/workflows/build.yml
Outdated
| if: | | ||
| github.event_name == 'pull_request' && ( | ||
| github.event.pull_request.draft || | ||
| contains(github.event.pull_request.title, 'WIP') |
There was a problem hiding this comment.
In my opinion, using the "title" to indicate that a PR doesn't need CI is less straightforward than simply marking it as a "draft." Perhaps a WIP could be interpreted as "this PR requires CI but doesn't need a review at the moment." That is a common use case in Kafka community.
There was a problem hiding this comment.
Yea, that's a good point. I went with the title since that's something non-committers can update (unlike labels). I'm fine leaving this out for now and just using the Draft status.
|
|
||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Update Check | ||
| - if: inputs.conclusion == '' |
There was a problem hiding this comment.
Pardon me, what is the purpose of this step?
There was a problem hiding this comment.
The checks API has status and conclusion. The conclusion is only given if the status is "completed".
If we want to set a check to pending (as we've discussed in other PRs), we would send status=pending with no conclusion.
Because of the two forms of API call needed (one with conclusion, one without), we needed two steps with different arguments.
There was a problem hiding this comment.
@mumrah, thanks for sharing. Although this step is not currently in use, it is intended to serve the needs of KAFKA-17607, right?
There was a problem hiding this comment.
Maybe you meant https://issues.apache.org/jira/browse/KAFKA-17572 (clearing a status when re-running a job)?
Reviewers: Chia-Ping Tsai <[email protected]>
This reverts parts of #17299 related to the checks API Reviewers: Chia-Ping Tsai <[email protected]>
Reviewers: Chia-Ping Tsai <[email protected]>
This reverts parts of apache#17299 related to the checks API Reviewers: Chia-Ping Tsai <[email protected]>
This patch updates our CI workflow to skip the JUnit tests if the PR is marked as a Draft. Also, change to using the more modern "checks" API instead of "statuses" for the feedback from CI Complete.