Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-17258: Migrate AdminFenceProducersIntegrationTest to ClusterTestExtensions framework #17311

Merged
merged 5 commits into from
Oct 2, 2024
Merged

KAFKA-17258: Migrate AdminFenceProducersIntegrationTest to ClusterTestExtensions framework #17311

merged 5 commits into from
Oct 2, 2024

Conversation

mingyen066
Copy link
Contributor

@mingyen066 mingyen066 commented Sep 28, 2024 •
edited
Loading

  • Migrate AdminFenceProducersIntegrationTest from scala to java and with ClusterTestExtensions framework
  • Suppress import control for the test

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added the core Kafka Broker label Sep 28, 2024
m1a2st
m1a2st reviewed Sep 29, 2024
View reviewed changes
Copy link
Contributor

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mingyen066, Thanks for your PR, left some comments, PTAL

m1a2st
m1a2st reviewed Sep 29, 2024
View reviewed changes
core/src/test/java/kafka/admin/AdminFenceProducersIntegrationTest.java Outdated Show resolved Hide resolved
core/src/test/java/kafka/admin/AdminFenceProducersIntegrationTest.java Outdated Show resolved Hide resolved
core/src/test/java/kafka/admin/AdminFenceProducersIntegrationTest.java Outdated Show resolved Hide resolved
core/src/test/java/kafka/admin/AdminFenceProducersIntegrationTest.java Outdated Show resolved Hide resolved
core/src/test/java/kafka/admin/AdminFenceProducersIntegrationTest.java Outdated Show resolved Hide resolved
core/src/test/java/kafka/admin/AdminFenceProducersIntegrationTest.java Outdated Show resolved Hide resolved
core/src/test/java/kafka/admin/AdminFenceProducersIntegrationTest.java Outdated Show resolved Hide resolved
core/src/test/java/kafka/admin/AdminFenceProducersIntegrationTest.java Outdated Show resolved Hide resolved
core/src/test/java/kafka/admin/AdminFenceProducersIntegrationTest.java Outdated Show resolved Hide resolved
@mingyen066 mingyen066 changed the title KAFKA-17258 Migrate AdminFenceProducersIntegrationTest to ClusterTestExtensions framework KAFKA-17258: Migrate AdminFenceProducersIntegrationTest to ClusterTestExtensions framework Sep 29, 2024
chia7712
chia7712 reviewed Sep 29, 2024
View reviewed changes
Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mingyen066 thanks for your patch

core/src/test/java/kafka/admin/AdminFenceProducersIntegrationTest.java Outdated Show resolved Hide resolved
m1a2st
m1a2st approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712
Copy link
Member

chia7712 commented Oct 2, 2024

@mingyen066 please fix build error

@mingyen066 mingyen066 force-pushed the KAFKA-17258-Migrate-AdminFenceProducersIntegrationTest-to-ClusterTestExtensions-framework branch from e40aaa0 to 2d8b370 Compare October 2, 2024 07:02
@mingyen066
Copy link
Contributor Author

@mingyen066 please fix build error

Thanks for reviewing! The build error has been fixed.
I forgot to run the build command before pushing the code.

@chia7712 chia7712 merged commit 540fb91 into apache:trunk Oct 2, 2024
9 checks passed
peterxcli
peterxcli reviewed Dec 15, 2024
View reviewed changes
core/src/test/java/kafka/admin/AdminFenceProducersTest.java
Comment on lines +70 to +79
private KafkaProducer<byte[], byte[]> createProducer() {
Properties config = new Properties();
config.put(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, clusterInstance.bootstrapServers());
config.put(ProducerConfig.TRANSACTIONAL_ID_CONFIG, TXN_ID);
config.put(ProducerConfig.TRANSACTION_TIMEOUT_CONFIG, "2000");
config.put(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG, ByteArraySerializer.class.getName());
config.put(ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG, ByteArraySerializer.class.getName());

return new KafkaProducer<>(config);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just discovered that this can be cleaned up with cluster.producer(configs)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you are right. Please feel free to open a MINOR to refactor it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. #18197. PTAL. Thanks!

@peterxcli peterxcli mentioned this pull request Dec 18, 2024
Merged
3 tasks
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
@mingyen066 @tedyu
KAFKA-17258 Migrate AdminFenceProducersIntegrationTest to ClusterTest…
ccdea62 
…Extensions framework (apache#17311)

Reviewers: Ken Huang <[email protected]>, Chia-Ping Tsai <[email protected]>
@mingyen066 mingyen066 deleted the KAFKA-17258-Migrate-AdminFenceProducersIntegrationTest-to-ClusterTestExtensions-framework branch January 30, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 approved these changes

@peterxcli peterxcli peterxcli left review comments

@m1a2st m1a2st m1a2st approved these changes

Assignees
No one assigned
Labels
ci-approved core Kafka Broker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mingyen066 @chia7712 @peterxcli @m1a2st