Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-17485: POC KIP-1088 KafkaClientInterceptor [DO NOT MERGE] #17333

Closed
wants to merge 5 commits into from

Conversation

mjsax
Copy link
Member

@mjsax mjsax commented Oct 1, 2024

The first commits are from #17330

Only KAFKA-17485: POC KIP-1088 KafkaClientsSupplier is relevant.

We don't pass in a client-supplier into `StreamsProducer` any longer,
so we can simplify `StreamsProducerTest` and remove client-supplier.
@mjsax mjsax added streams kip Requires or implements a KIP labels Oct 1, 2024
import java.util.HashMap;
import java.util.Map;

public class KafkaClientInterceptor implements Configurable {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we would want to make this an interface similar to KafakClientSuppplier plus its impl class DefaultKafkaClientSupplier

@mumrah mumrah added the do-not-merge PRs that are only open temporarily and should not be merged label Oct 1, 2024
Copy link

github-actions bot commented Jan 5, 2025

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions bot added the stale Stale PRs label Jan 5, 2025
Copy link

github-actions bot commented Feb 6, 2025

This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.

@github-actions github-actions bot added the closed-stale PRs that were closed due to inactivity label Feb 6, 2025
@github-actions github-actions bot closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-stale PRs that were closed due to inactivity do-not-merge PRs that are only open temporarily and should not be merged kip Requires or implements a KIP stale Stale PRs streams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants