-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-17485: POC KIP-1088 KafkaClientInterceptor [DO NOT MERGE] #17333
Conversation
We don't pass in a client-supplier into `StreamsProducer` any longer, so we can simplify `StreamsProducerTest` and remove client-supplier.
import java.util.HashMap; | ||
import java.util.Map; | ||
|
||
public class KafkaClientInterceptor implements Configurable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we would want to make this an interface similar to KafakClientSuppplier
plus its impl class DefaultKafkaClientSupplier
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java
Outdated
Show resolved
Hide resolved
…logyTestDriver.java
This PR is being marked as stale since it has not had any activity in 90 days. If you If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact). If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
This PR has been closed since it has not had any activity in 120 days. If you feel like this |
The first commits are from #17330
Only
KAFKA-17485: POC KIP-1088 KafkaClientsSupplier
is relevant.