KAFKA-17685 make sure all modules have consistent testRuntimeOnly dependencies #17355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1a2st
changed the title
mumrah
approved these changes
Oct 3, 2024
build.gradle
Outdated
Comment on lines
127
to
128
| libs.slf4jReload4j, | ||
| libs.junitPlatformLanucher, |
mumrah
reviewed
Oct 3, 2024
build.gradle
Outdated
| @@ -122,6 +122,11 @@ ext { | |||
| if (name == "compileTestJava" || name == "compileTestScala") | |||
| options.compilerArgs << "-parameters" | |||
| } | |||
|
|
|||
| runtimeLibs = [ | |||
There was a problem hiding this comment.
Should also call this "runtimeTestLibs" probably to avoid confusion.
There was a problem hiding this comment.
Thanks, It make sense to me
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
Reviewers: David Arthur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/KAFKA-17685
we declare a variable of runtimeLibs to simplfied the testRuntimeOnly dependency
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)