Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-17714: Fix StorageToolTest.scala to compile under Scala 2.12 #17400

Merged
merged 1 commit into from
Oct 8, 2024
Merged

KAFKA-17714: Fix StorageToolTest.scala to compile under Scala 2.12 #17400

merged 1 commit into from
Oct 8, 2024

Conversation

cmccabe
Copy link
Contributor

@cmccabe cmccabe commented Oct 7, 2024

No description provided.

@github-actions github-actions bot added streams core Kafka Broker producer consumer tools connect performance kraft mirror-maker-2 storage Pull requests that target the storage module build Gradle build or GitHub Actions docker Official Docker image clients labels Oct 7, 2024
@github-actions github-actions bot added tests Test fixes (including flaky tests) small Small PRs labels Oct 7, 2024
@github-actions github-actions bot added the tools label Oct 7, 2024
@github-actions github-actions bot added the small Small PRs label Oct 7, 2024
@chia7712
Copy link
Member

chia7712 commented Oct 7, 2024

As @jolshan comment in the jira, the 2.12 was removed from trunk (see #17313).

@cmccabe is there any specific reason the storage tool must be compilable under Scala 2.12?

@cmccabe cmccabe changed the base branch from trunk to 3.9 October 7, 2024 23:10
@cmccabe
Copy link
Contributor Author

cmccabe commented Oct 7, 2024 •
edited
Loading

As @jolshan comment in the jira, the 2.12 was removed from trunk (see #17313).

@cmccabe is there any specific reason the storage tool must be compilable under Scala 2.12?

Sorry, this was supposed to be for the 3.9 branch. I changed the PR.

As you know, the 3.9 branch still supports Scala 2.12 so this is needed for the release.

@mumrah mumrah removed tests Test fixes (including flaky tests) build Gradle build or GitHub Actions labels Oct 8, 2024
mumrah
mumrah approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmccabe I checked out the PR and it builds locally with Scala 2.12 and 2.13

I see the PR refers to StorageTool.scala, but the only change is to StorageToolTest.scala. I'm guessing that's intentional since the code compiles. Can you update the title?

LGTM. I don't think we need to wait on Jenkins if this is just a 2.12 compile fix for a test.

@chia7712 chia7712 merged commit 0a70c3a into apache:3.9 Oct 8, 2024
1 check was pending
@chia7712 chia7712 changed the title KAFKA-17714: Fix StorageTool.scala to compile under Scala 2.12 KAFKA-17714: Fix StorageToolTest.scala to compile under Scala 2.12 Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumrah mumrah mumrah approved these changes

@chia7712 chia7712 chia7712 approved these changes

@jolshan jolshan jolshan approved these changes

Assignees
No one assigned
Labels
core Kafka Broker small Small PRs tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmccabe @chia7712 @mumrah @jolshan