KAFKA-19047: Broker registrations are slow if previously fenced or shutdown #19296
+127
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splett2
reviewed
Mar 27, 2025
| @@ -353,7 +353,7 @@ public ControllerResult<BrokerRegistrationReply> registerBroker( | |||
| if (existing != null) { | |||
| prevIncarnationId = existing.incarnationId(); | |||
| storedBrokerEpoch = existing.epoch(); | |||
| if (heartbeatManager.hasValidSession(brokerId, existing.epoch())) { | |||
| if (heartbeatManager.hasValidSession(brokerId, existing.epoch()) && heartbeatManager.isBrokerActive(brokerId)) { | |||
There was a problem hiding this comment.
could we just check if whether existing is fenced or in controlled shutdown?
ahuang98
changed the title
splett2
reviewed
Mar 27, 2025
| assertEquals(OptionalLong.of(1000L), clusterControl.heartbeatManager().tracker(). | ||
| contactTime(new BrokerIdAndEpoch(1, 200))); | ||
|
|
||
| // even if session is still valid for old brokers, new registrations will succeed |
There was a problem hiding this comment.
nit: I think the wording here should be something along the lines of:
new registrations should succeed if a broker is fenced or in controlled shutdown, even if the last heartbeat was within the session timeout
splett2
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow registration if prior broker state was fenced or in controlled shutdown.