KAFKA-19824: New AllowlistConnectorClientConfigOverridePolicy (KIP-1188) #20750
+244
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @C0urante @AndrewJSchofield @showuon as you voted on the KIP. Thanks |
C0urante
reviewed
Oct 26, 2025
| * {@code Principal}. This allows to set a principal per connector. | ||
| * @deprecated Use {@link AllowlistConnectorClientConfigOverridePolicy} instead. | ||
| */ | ||
| @Deprecated(since = " 4.2", forRemoval = true) |
There was a problem hiding this comment.
Can we add a warning log message when this class is instantiated to notify users about its deprecation and what steps they should take to prepare for its removal?
AndrewJSchofield
approved these changes
Oct 27, 2025
| public static final String CONNECTOR_CLIENT_POLICY_CLASS_CONFIG = "connector.client.config.override.policy"; | ||
| public static final String CONNECTOR_CLIENT_POLICY_CLASS_DOC = | ||
| "Class name or alias of implementation of <code>ConnectorClientConfigOverridePolicy</code>. Defines what client configurations can be " | ||
| + "overridden by the connector. The default implementation is <code>All</code>, meaning connector configurations can override all client properties. " |
There was a problem hiding this comment.
nit: "The default policy" reads a little better than "The default implementation" given that the others are described as policies.
There was a problem hiding this comment.
I agree, updated. Thanks
| ConfigInfos result = herder.validateConnectorConfig(config, s -> null, false); | ||
| assertEquals(ConnectorType.SOURCE, herder.connectorType(config)); | ||
|
|
||
| // We expect there to be errors due to sasl.jaas.config not being allowed Note that these assertions depend heavily on |
There was a problem hiding this comment.
nit: Missing "." before "Note"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements KIP-1188