Skip to content

KAFKA-16024: SaslPlaintextConsumerTest#testCoordinatorFailover is flaky #20774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 29, 2025
Merged

KAFKA-16024: SaslPlaintextConsumerTest#testCoordinatorFailover is flaky #20774

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5c7246c
KAFKA-16024: SaslPlaintextConsumerTest#testCoordinatorFailover is flaky
brandboat Oct 25, 2025
78828b0
debug
brandboat Oct 25, 2025
fe1bb6a
Revert "debug"
brandboat Oct 27, 2025
c99f3a0
enable controlled shutdown
brandboat Oct 29, 2025
9b71fa1
Merge remote-tracking branch 'origin/trunk' into KAFKA-16024
brandboat Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions core/src/test/scala/integration/kafka/api/BaseConsumerTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ import org.apache.kafka.clients.producer.{KafkaProducer, ProducerConfig}
import org.apache.kafka.common.{ClusterResource, ClusterResourceListener, PartitionInfo}
import org.apache.kafka.common.internals.Topic
import org.apache.kafka.common.serialization.{Deserializer, Serializer}
import org.apache.kafka.server.config.ServerConfigs
import org.junit.jupiter.api.Assertions._
import org.junit.jupiter.api.{BeforeEach, TestInfo}
import org.junit.jupiter.params.ParameterizedTest
import org.junit.jupiter.params.provider.MethodSource

Expand All @@ -36,6 +38,25 @@ import scala.collection.Seq
*/
abstract class BaseConsumerTest extends AbstractConsumerTest {

private var currentTestName: String = _

@BeforeEach
override def setUp(testInfo: TestInfo): Unit = {
currentTestName = testInfo.getTestMethod.get().getName
super.setUp(testInfo)
}

override protected def brokerPropertyOverrides(properties: Properties): Unit = {
super.brokerPropertyOverrides(properties)

if (currentTestName != null && currentTestName.equals("testCoordinatorFailover")) {
// Enable controlled shutdown to allow the broker to notify the controller before shutting down.
// This speeds up the test by triggering an immediate failover instead of waiting for the
// broker session timeout (default: 9s) to expire.
properties.setProperty(ServerConfigs.CONTROLLED_SHUTDOWN_ENABLE_CONFIG, "true")
}
}

@ParameterizedTest(name = TestInfoUtils.TestWithParameterizedGroupProtocolNames)
@MethodSource(Array("getTestGroupProtocolParametersAll"))
def testSimpleConsumption(groupProtocol: String): Unit = {
Expand Down
Loading