KAFKA-20116: Fix reporting task-(end)-offset sum for "streams" protocol - #23013
Open
mjsax wants to merge 1 commit into
Open
KAFKA-20116: Fix reporting task-(end)-offset sum for "streams" protocol#23013mjsax wants to merge 1 commit into
mjsax wants to merge 1 commit into
Conversation
This PR ensures that we are assembling the latest task-(end)-offset sum snapshot only for the "streams" protocol, but not for "classic". For "classic" the snapshot is never read, so it's unnecessary to maintain it. It further ensure that we refresh the task-(end)-offset sum snapshot even if the main loop is not ready to process active tasks. The async state-updater thread might still make progress restoring standby and warmup tasks, so we should continue reporting the most recent metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that we are assembling the latest task-(end)-offset sum
snapshot only for the "streams" protocol, but not for "classic". For
"classic" the snapshot is never read, so it's unnecessary to maintain
it.
It further ensure that we refresh the task-(end)-offset sum snapshot
even if the main loop is not ready to process active tasks. The async
state-updater thread might still make progress restoring standby and
warmup tasks, so we should continue reporting the most recent metadata.