KAFKA-20869: Guard stream thread addition for global-only topologies - #23022
Open
lh0156 wants to merge 1 commit into
Open
KAFKA-20869: Guard stream thread addition for global-only topologies#23022lh0156 wants to merge 1 commit into
lh0156 wants to merge 1 commit into
Conversation
Prevent addStreamThread from creating a local stream thread when the topology has no local processing tasks. Add a regression test covering a running global-only client. Generated-by: OpenAI Codex (GPT-5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent KafkaStreams#addStreamThread from creating a local StreamThread when the topology has no local processing tasks.
Motivation
Global-only topologies intentionally start with zero local StreamThreads, even when num.stream.threads is configured with a positive value. Calling addStreamThread after startup must preserve that topology invariant; otherwise it creates a StreamThread that cannot build local tasks and can crash the client or repeatedly trigger thread replacement.
Testing
Fixes KAFKA-20869