KAFKA-20860: Retry consumer reconciliation after synchronous failure - #23023
Open
lh0156 wants to merge 1 commit into
Open
KAFKA-20860: Retry consumer reconciliation after synchronous failure#23023lh0156 wants to merge 1 commit into
lh0156 wants to merge 1 commit into
Conversation
Ensure a synchronous exception during reconciliation setup does not leave the membership manager permanently blocked. Preserve commit failure handling while allowing the next reconciliation loop to retry. Generated-by: OpenAI Codex (GPT-5)
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
A RuntimeException thrown after reconciliation starts but before its asynchronous future chain is established can leave the membership manager permanently stuck because
reconciliationInProgressremains true. This change treats that setup failure as a failed attempt, preserves the existing auto-commit failure behavior, and allows the next poll to retry.Testing
./gradlew :clients:test --tests org.apache.kafka.clients.consumer.internals.ConsumerMembershipManagerTest./gradlew :clients:test --tests org.apache.kafka.clients.consumer.internals.ConsumerMembershipManagerTest --tests org.apache.kafka.clients.consumer.internals.StreamsMembershipManagerTest --tests org.apache.kafka.clients.consumer.internals.ShareMembershipManagerTest./gradlew :clients:check --no-build-cache --console=plainFixes KAFKA-20860
Reviewers: Lianet Magrans lmagrans@confluent.io