MINOR: Batch the produce in Connect integration tests - #23028
Open
mingyen066 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EmbeddedKafkaCluster#produce only accepts one record and blocks on
send().get(), so callers that need many records have to loop and pay a
round trip per record. Each of those round trips also waits out
linger.ms for a batch that can never fill, because the caller is blocked
in get(). Six call sites across four integration test classes produce
~11,000 records this way.
Add a produce(List<ProducerRecord<byte[], byte[]>>) overload that sends
the whole list before awaiting any acknowledgement, and have the
single-record overloads delegate to it. Blocking behaviour is unchanged.
Measured with -PmaxParallelForks=1, two runs per side:
Total for these four classes: 149.2s -> 87.4s.