KAFKA-20866: Remove incremental-only append result state - #23032
Open
lh0156 wants to merge 1 commit into
Open
Conversation
Generated-by: OpenAI Codex (GPT-5)
github-actions
Bot
added
triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RecordAppendResultis created for every successful append. This change removes the incremental-strategy-onlyoutcomeandextensionBytesNeededfields from regular results. Buffer-extension capacity is now held only by a private result subtype, while the existing append/new-batch behavior remains unchanged.The chunked accumulator consumes the capacity through a package-private accessor, and a regression test covers the buffer-extension result contract.
Testing
The implementation followed a TDD cycle:
extensionBytesNeeded()did not exist.Validated with:
./gradlew :clients:test --tests org.apache.kafka.clients.producer.internals.RecordAccumulatorTest --tests org.apache.kafka.clients.producer.internals.ChunkedRecordAccumulatorTest --no-build-cache --console=plain./gradlew :clients:test --no-build-cache --console=plain./gradlew :clients:spotlessJavaCheck --no-build-cache --console=plainThe clients test task also ran checkstyle and SpotBugs successfully.