Repository navigation
Fixes from the 2026-11 audit, part 1 - #355
Merged
Merged
Conversation
FreeAndNil
force-pushed
the
Feature/2026-11-audit-part-1
branch
from
November 9, 2026 19:55
d9276a8 to
7b0dd1f
Compare
…-2PJSIJWL) - Both IndexOf calls in Transform.WriteEscapedXmlString
…l appenders (ANT-2026-3WK17LYB) - Escaping encoder fallback in ContentEscape, all four hand-offs
- Analyzers 10.0.114, 8.0.0 flags extension members with CA1822 - SmtpAppender validates messageBody for CA1062 - Tests look up ContentEscape once
- Message and category, both reach the same native call - Tests for both Debug.Write overloads, listener records every write - Docs on the trace appender page, API remarks, changelog
- NUL and lone surrogates escaped before binding, Size cut keeps pairs whole - Docs and changelog ask for a UTF-8 database, name the string types
- Give up only while the database has not accepted an insert - Manual documents the cap, the first-five gap and the round trip cost - Fake provider reset in SetUp, remarks corrected
- Per-event writer in RenderLoggingEvent, categories of Trace, Debug and AspNetTrace - Pattern width cut keeps surrogate pairs whole - Trace and Debug report a failed flush, sink calls in Telnet and SmtpPickupDir removed
…5JHYT) - TruncateToBytes in small chunks, keeps characters and pairs whole - UdpAppender docs name both default encodings - VB.NET receiver sample removed, C# sample fixed
- FromAsync plus ContinueWith as before 3.0.0, deterministic nesting test - Failed accept logged or retried after 100 ms, the delay untested on purpose - Late accept and late client after Dispose closed
…HYT) - Default 204800 UTF-8 bytes, cut before EscapePercent, per line in Split mode - Each cut reported through ErrorHandler - Records computed by a private method, tested by reflection
…-D8I8WODV) - MailBodies shared by Ext.Mail and the legacy SmtpAppender, default 1 MiB - Each mail sent on its own, one enqueue deadline per batch - Oversize record cut, no-room header and footer reported at activation
- Base64 for UTF-16 and UTF-32, where CR and LF bytes occur inside characters - Fake transport keeps the raw message, tests for a bare CR on every code page - README, manual and changelog name the encoding and the wire size
- ContentEscape.EscapeLoneCarriageReturns, a regex, CRLF kept - Each event rendered to a string and escaped before it is written - Manual names Sendmail and the CR at an event boundary
…-2026-SWV3M1YH) - HttpRequestExtensions: Classic taken, Buffered tried, None and Bufferless left out - Keyed lookup in the indexer order without an unread form - net462 tests incl. buffered and bufferless reads, XML remark and manual note
FreeAndNil
force-pushed
the
Feature/2026-11-audit-part-1
branch
from
November 9, 2026 20:10
7b0dd1f to
6fe906d
Compare
FreeAndNil
added a commit
that referenced
this pull request
Nov 9, 2026
- PR link and ANT id in all 13 entries - bump version to 3.6.0
FreeAndNil
added a commit
that referenced
this pull request
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the 2026-11 audit, part 1