fix(architecture): dedupe vendor badges in the per-contract score#77
Merged
Merged
Conversation
The per-contract score cards rendered one vendor badge per implementing tool, so a vendor shipping several tools showed duplicate badges (e.g. GitHub ×3 on contract:tracker, Atlassian ×2 on contract:change-request) — inconsistent with the "N backend vendors: …" line that already lists distinct vendors. Add a vendorsOf() helper that groups implementations by vendor and renders one badge per distinct vendor (sorted to match the basis line); the badge tooltip now aggregates all of that vendor's tools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Per-contract score cards on
/architecturerendered one vendor badgeper implementing tool, so a vendor shipping several tools showed duplicate
badges — inconsistent with the "N backend vendors: …" line that already lists
distinct vendors.
Visible cases:
contract:tracker— GitHub ×3 (6 tools → 4 distinct vendors)contract:change-request— Atlassian ×2 (4 tools → 3 distinct vendors)Fix
vendorsOf()helper groups a contract's implementations by vendor andrenders one badge per distinct vendor, sorted to match the basis line.
three tools).
Verification
npm run buildclean (122 pages); confirmed against the data that onlytracker(6→4) andchange-request(4→3) had duplicates, now resolved.🤖 Generated with Claude Code