Skip to content

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Sep 16, 2025

start on #1316

test fails by IOException if the directory can't be deleted. The asserts never fail if they're reached.

@elharo elharo requested a review from Copilot September 16, 2025 12:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unnecessary setup code from the ScmTestCase class that performed redundant assertions after directory deletions. The change eliminates assert statements that verified directories were deleted and removes an unused import and variable assignment.

  • Removes assertFalse statements that checked directory deletion
  • Removes unused assertFalse import
  • Removes redundant scmManager = null assignment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@elharo elharo marked this pull request as ready for review September 17, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant