Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quickstart.adoc #644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

SeanCarrick
Copy link
Contributor

Updated only the review date for this tutorial. Everything in it looks good.

Should we create a separate tutorial for each build system?

-SC

Updated only the review date for this tutorial. Everything in it looks good. 

Should we create a separate tutorial for each build system?

-SC
@vieiro
Copy link
Contributor

vieiro commented Feb 26, 2023

Hi @SeanCarrick , I don't understand why you're updating the review date. I mean, this was reviewed in 2019 and is still OK. Any reason why we would like to change this date?

@SeanCarrick
Copy link
Contributor Author

Sorry, I thought that we were supposed to update the review date when we reviewed it. I'm understanding you are saying to only update it if there are changes, correct?

@mbien
Copy link
Member

mbien commented Feb 26, 2023

i think it would be better to concentrate on the pages which never got a review and are explicitly marked with needs-review.

however, the numbered list seems to be broken on this page here too, looks like there is something to fix after all :)

see: https://netbeans.apache.org/kb/docs/java/quickstart.html
first list is a series of 1s

@vieiro
Copy link
Contributor

vieiro commented Feb 26, 2023

Sorry, I thought that we were supposed to update the review date when we reviewed it. I'm understanding you are saying to only update it if there are changes, correct?

Yep. the :reviewed: tag is there just for us to know that someone has reviewed the page, if there's no need to review it again then no need to change the date :-).

@SeanCarrick
Copy link
Contributor Author

@vieiro understood!

@mbien On it!

-SC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants