games/snake: Fix terminal issue after returning back from snake game #3126
+48
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eren-terzioglu
force-pushed
the
bugfix/snake_game_return
branch
from
ed64ae5 to
6289917
Compare
|
Thanks @xiaoxiang781216, updated. |
xiaoxiang781216
approved these changes
Jul 12, 2025
acassis
reviewed
Jul 15, 2025
jerpelea
previously approved these changes
Jul 15, 2025
xiaoxiang781216
requested changes
Jul 15, 2025
eren-terzioglu
force-pushed
the
bugfix/snake_game_return
branch
from
6289917 to
6a988df
Compare
|
Thanks @acassis @xiaoxiang781216, updated. |
acassis
approved these changes
Jul 15, 2025
Fix terminal issue after returning back from game Signed-off-by: Eren Terzioglu <[email protected]>
Change consolekey magic numbers with ascii values to make it more understandable Signed-off-by: Eren Terzioglu <[email protected]>
xiaoxiang781216
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When snake game with
GAMES_SNAKE_USE_CONSOLEKEYoption enabled, nsh crashes after returning from the game. This PR fixes the issueFix terminal issue after returning back from game
Impact
Snake game
Testing
esp32-devkitc:snakeconfig withGAMES_SNAKE_USE_CONSOLEKEYandDEBUG_SNAKE_GAMEoptions enabled. You can recreate issue by pressing left arrow key at the end of the game. Expected issue is 'nsh' will act weird and echo option would not work.