Skip to content

cargo: upgrade jsonwebtoken #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tisonkun merged 1 commit into from
Feb 25, 2026
Merged

cargo: upgrade jsonwebtoken #689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ hex = "0.4"
hmac = "0.12"
http = "1"
jiff = "0.2"
jsonwebtoken = { version = "10", features = ["aws_lc_rs"] }
Copy link
Member

@Xuanwo Xuanwo Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this always enable aws_lc_rs? Our downstream users, such as opendal, want to allow users to choose their own cryptography implementation.

Copy link
Contributor Author

@xnox xnox Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no choice of cryptography implementations; and other dependencies of opendal-reqsign already require aws_lc_rs. Thus this is no change in dependencies.

Copy link
Contributor Author

@xnox xnox Feb 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this dependency has no affect on rustls backend in use.

Copy link
Member

@tisonkun tisonkun Feb 25, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and other dependencies of opendal-reqsign already require aws_lc_rs

Yes. This is mainly pulled in from reqwest 0.13's default-tls.

We may have a follow-up to investigate whether we can make it optional (switchable between aws-lc-rs and ring).

I personally don't like aws-lc-rs too much since it pulls in cmake and other build hazards. But it's the trend, and I don't find too many motivations to build a replacement now.

log = "0.4"
percent-encoding = "2"
pretty_assertions = "1.3"
Expand Down
2 changes: 1 addition & 1 deletion services/azure-storage/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ serde_json = { workspace = true }
sha1 = { workspace = true }

[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
jsonwebtoken = "9.2"
jsonwebtoken = { workspace = true }
pem = "3.0"
rsa = { workspace = true }

Expand Down
2 changes: 1 addition & 1 deletion services/google/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ rust-version.workspace = true
async-trait = { workspace = true }
form_urlencoded = { workspace = true }
http = { workspace = true }
jsonwebtoken = "9.2"
jsonwebtoken = { workspace = true }
log = { workspace = true }
percent-encoding = { workspace = true }
rand = { workspace = true }
Expand Down
Loading