Skip to content

Conversation

@jzonthemtn
Copy link
Contributor

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@mawiesne mawiesne changed the title OPENNLP-1770: Updating logo for docs. OPENNLP-1770: Updating logo for docs Nov 21, 2025
@mawiesne mawiesne requested a review from rzo1 November 21, 2025 21:22
@rzo1
Copy link
Contributor

rzo1 commented Nov 22, 2025

Note: needs cherry picking to 2.x as well

@atarora
Copy link
Contributor

atarora commented Nov 24, 2025

Looks good!
A nitpick - feel free to ignore, the TM in the original logo seems missing in the new one.

@jzonthemtn
Copy link
Contributor Author

Looks good! A nitpick - feel free to ignore, the TM in the original logo seems missing in the new one.

I wondered about that, too. This logo came from ASF M&P so I would expect it should be made per the ASF policy and adhere to the trademark rules...? I can make a note to ping them and see.

@mawiesne mawiesne marked this pull request as draft November 25, 2025 06:44
@mawiesne
Copy link
Contributor

I can make a note to ping them and see.

Put the PR to draft mode until feedback has arrived.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants