HDDS-14954. Add logging and metric for SCM safemode duration.#10018
Merged
Conversation
Contributor
|
Thanks for adding this @sadanand48. Let's add new safemode metrics to the safemode dashboard as well. |
sreejasahithi
left a comment
sreejasahithi
left a comment
Contributor
There was a problem hiding this comment.
Thanks @sadanand48 for working on this.
Could you please add the Grafana dashboard screenshots to the PR description.
sadanand48
requested review from
aryangupta1998 and
sreejasahithi
and removed request for
sreejasahithi
aryangupta1998
approved these changes
May 18, 2026
aryangupta1998
left a comment
aryangupta1998
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch, LGTM!
sreejasahithi
approved these changes
May 18, 2026
sreejasahithi
left a comment
sreejasahithi
left a comment
Contributor
There was a problem hiding this comment.
Thanks @sadanand48
LGTM
Contributor
Author
|
Thanks @sreejasahithi @errose28 @aryangupta1998 for the reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a metric for :
We need this because in large clusters it is observed that refresh takes a lot of time. This can be used for monitoring.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14954