HDDS-15121. Unify SCM list container on SCMListContainerRequestProto#10144
Open
sarvekshayr wants to merge 3 commits into
Open
HDDS-15121. Unify SCM list container on SCMListContainerRequestProto#10144sarvekshayr wants to merge 3 commits into
sarvekshayr wants to merge 3 commits into
Conversation
sreejasahithi
left a comment
sreejasahithi
left a comment
Contributor
There was a problem hiding this comment.
Thanks @sarvekshayr
|
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days. |
|
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days. |
|
Thank you for your contribution. This PR is being closed due to inactivity. Please contact a maintainer if you would like to reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Unified SCM list-container on one protobuf (
SCMListContainerRequestProto) and one Java carrier (ListContainerQuery), withScmListContainerRequestCodecbridging paging + optional filters (state, replication, suppressed, etc.).Drop the old
listContainer(long, …)overloads fromStorageContainerLocationProtocol, the client side PB translator, andSCMClientProtocolServer; keep thin@Deprecatedwrappers onScmClient/ContainerOperationClientthat assemble aListContainerQueryvianewBuilder(start, count).…build().Additional list behavior is added as optional proto fields,
ListContainerQuerybuilder setters, codec encode/decode, and server filter/audit, without wideninglistContainerwith more Java overloads onStorageContainerLocationProtocol.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15121
How was this patch tested?
CI: https://github.com/sarvekshayr/ozone/actions/runs/24960197016