HDDS-14578. Ozone admin command gives inconsistent error messages on expired keytab.#10160
Conversation
…r details on expired keytab
|
Thanks @sravani-revuri for the patch. Are you planning to make admin commands more consistent, or just clarifying |
I will be doing it for the other admin commands error messages mentioned in the jira. the jira was initially just for the container info command, but i had found some more inconsistencies. Updated the jira to handle it in this PR itself. Will update the testing proof once i'm done. |
|
@sravani-revuri For the other ozone admin commands which need to have clear error message, please update about it in the PR description. |
|
@Gargi-jais11 could you please take a look at these changes? |
sreejasahithi
left a comment
There was a problem hiding this comment.
Thanks @sravani-revuri for working on this
LGTM
Gargi-jais11
left a comment
There was a problem hiding this comment.
Thanks @sravani-revuri fixing this. LGTM!
|
@adoroszlai Do you want to have look into this? |
|
Thanks @sravani-revuri for working on this. I think these messages are still inconsistent:
Would it be possible to simply print |
Agreed, just the |
|
@sarvekshayr , @adoroszlai could you please take a look at these changes. |
|
I'm seeing the below exception for |
FYI this happens in non-HA cluster. |
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @sravani-revuri for updating the patch.
@sarvekshayr , the admin commands in non-ha cluster now give the same error message. could you please take a look at these chnages. |
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @sravani-revuri for updating the patch. Please revert changes that are unnecessary now that the command exits on access denied.
sarvekshayr
left a comment
There was a problem hiding this comment.
Thanks for addressing all the comments @sravani-revuri.
LGTM.
|
Thanks @sravani-revuri for the patch, @adoroszlai, @Gargi-jais11 and @sreejasahithi for the review. |
What changes were proposed in this pull request?
Ozone admin command gives inconsistent error messages on expired keytab for the following commands.
Works again on renewing the Kerberos credentials
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14578
How was this patch tested?
Manual test of ozone admin commands.
Reconcile command:
manula and unit test.
no keytab:
non ratis contianer: (failure not form authentication)
normal: