HDDS-13855. Add integration tests for ACL enforcement after leadership change - #10331
Closed
ss77892 wants to merge 1 commit into
Closed
HDDS-13855. Add integration tests for ACL enforcement after leadership change#10331ss77892 wants to merge 1 commit into
ss77892 wants to merge 1 commit into
Conversation
…p change Add HA integration tests to TestOMHALeaderSpecificACLEnforcement covering ACL enforcement in preExecute for: - Volume operations: delete, set-owner, set-quota - Bucket operations: delete, set-owner, set-property - Key bulk operations: delete-keys, rename-keys - Key ACL operations: add/remove/set ACL (FSO layout) Each test triggers a leadership change and verifies that unauthorized requests are rejected before a Ratis log entry is written, confirming that the ACL check runs in preExecute on the new leader. Co-authored-by: Cursor <cursoragent@cursor.com>
|
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days. |
|
Thank you for your contribution. This PR is being closed due to inactivity. Please contact a maintainer if you would like to reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestOMHALeaderSpecificACLEnforcementwith 8 new test methods covering all operations changed in HDDS-13855testVolumeDeleteAclEnforcementAfterLeadershipChange,testVolumeSetOwnerAclEnforcementAfterLeadershipChange,testVolumeSetQuotaAclEnforcementAfterLeadershipChangetestBucketDeleteAclEnforcementAfterLeadershipChange,testBucketSetOwnerAclEnforcementAfterLeadershipChange,testBucketSetPropertyAclEnforcementAfterLeadershipChangetestKeysDeleteAclEnforcementAfterLeadershipChange,testKeysRenameAclEnforcementAfterLeadershipChangetestKeyAclOperationsEnforcementAfterLeadershipChangeWithFSOMotivation
Each test triggers an OM leadership change and then attempts an unauthorized operation. The test verifies that the request is rejected (throwing
OMException) before a Ratis log entry is written, confirming that ACL enforcement now runs inpreExecuteon the new leader.Test plan
TestOMHALeaderSpecificACLEnforcementpasses all new test methodsDependencies
Depends on the three implementation PRs:
Made with Cursor