HDDS-10237. Dynamic reconfiguration of replication supervisor thread pool - #10403
Merged
Conversation
adoroszlai
reviewed
Jun 1, 2026
adoroszlai
left a comment
adoroszlai
left a comment
Contributor
There was a problem hiding this comment.
Thanks @Russole for the patch, LGTM.
yandrey321
reviewed
Jun 1, 2026
| rs.setReplicationMaxStreams(7); | ||
| assertEquals(7, threadPoolSize.get()); | ||
|
|
||
| rs.nodeStateUpdated(DECOMMISSIONING); |
Contributor
There was a problem hiding this comment.
this test assumes OUTOFSERVICE_FACTOR_DEFAULT_VALUE=2, but since its configurable its better use config value in calculating expected value in assert.
Contributor
Author
There was a problem hiding this comment.
Good catch, updated to use the configured factor.
Contributor
Author
|
Hi @adoroszlai, I made a small update to address the latest comment. Would you like to take another look? |
Contributor
|
Thanks @Russole for the patch, @yandrey321 for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ReplicationSupervisorwhenhdds.datanode.replication.streams.limitis reconfigured dynamically.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10237
How was this patch tested?
ReplicationSupervisorresize on stream limit reconfiguration.mvn -pl hadoop-hdds/container-service -Dtest=TestReplicationSupervisor test