Skip to content

HDDS-15084. Core Runtime: SCM + OM#10456

Merged
peterxcli merged 1 commit into
apache:masterfrom
henrybear327:HDDS-15084-core-runtime
Jul 13, 2026
Merged

HDDS-15084. Core Runtime: SCM + OM#10456
peterxcli merged 1 commit into
apache:masterfrom
henrybear327:HDDS-15084-core-runtime

Conversation

@henrybear327

@henrybear327 henrybear327 commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

This PR adds the core SCM and OM runtime support for ozone local.

ozone local currently has the local filesystem and configuration lifecycle from HDDS-15083. This change builds on that base and updates LocalOzoneCluster so it can initialize SCM/OM storage, start StorageContainerManager and OzoneManager in process, wait for scoped runtime readiness, and shut the services down cleanly.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-15084

How was this patch tested?

https://github.com/apache/ozone/actions/runs/27076487958

mvn test -pl hadoop-ozone/tools -Dtest=TestLocalOzoneCluster
mvn test -pl hadoop-ozone/integration-test -Dtest=TestLocalOzoneClusterRuntime

@henrybear327

Copy link
Copy Markdown
Contributor Author

cc: @peterxcli

@chungen0126
chungen0126 requested a review from peterxcli June 8, 2026 11:57
@rich7420

rich7420 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@henrybear327 thanks for the patch, this reads really cleanly!

but I got one thought: a lot of the bring-up here (storage init, port allocation, readiness, shutdown) overlaps with what MiniOzoneClusterImpl already does. Did you consider building on it or extracting a shared piece, so the two don't drift apart as SCM/OM init changes? Not a blocker — just curious if it was ruled out for a reason. Thanks!

@adoroszlai adoroszlai added the ozone-local HDDS-14893 label Jun 10, 2026
@henrybear327
henrybear327 force-pushed the HDDS-15084-core-runtime branch from 6b3ce79 to 5b2ea1c Compare June 21, 2026 23:40
@henrybear327

Copy link
Copy Markdown
Contributor Author

@henrybear327 thanks for the patch, this reads really cleanly!

but I got one thought: a lot of the bring-up here (storage init, port allocation, readiness, shutdown) overlaps with what MiniOzoneClusterImpl already does. Did you consider building on it or extracting a shared piece, so the two don't drift apart as SCM/OM init changes? Not a blocker — just curious if it was ruled out for a reason. Thanks!

Hi @rich7420 , thanks for the question.

I think this stream of work is quite different from the MiniOzoneClusterImpl implementation.

MiniOzoneClusterImpl lives in ozone-mini-cluster, a test-only module (it depends on hdds-test-utils) that isn't packaged into the distribution.

ozone local ships from ozone-tools and is meant to be run directly via the CLI, so the use case is quite different and the implementations will diverge in the long run — configuration, node setup, persistent ports (e.g. ports.properties for devcontainer/compose reuse vs. MiniOzoneCluster's random ephemeral ports), etc.

Not sure if this answers your question!

@henrybear327

Copy link
Copy Markdown
Contributor Author

cc: @chungen0126 @peterxcli for a review! Thank you!

@peterxcli
peterxcli requested a review from chungen0126 June 22, 2026 10:51
@henrybear327
henrybear327 force-pushed the HDDS-15084-core-runtime branch from 5b2ea1c to 626bd46 Compare July 4, 2026 21:06
@henrybear327

henrybear327 commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

Rebased. PTAL @peterxcli @chungen0126 :) Thanks

This should unblock #10159 so we can move forward.

@henrybear327
henrybear327 force-pushed the HDDS-15084-core-runtime branch 2 times, most recently from 6211f71 to 228f03f Compare July 5, 2026 08:50

@chungen0126 chungen0126 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @henrybear327 for the patch. Left some comments.

@henrybear327
henrybear327 force-pushed the HDDS-15084-core-runtime branch from 228f03f to 95409e3 Compare July 13, 2026 11:35
@henrybear327
henrybear327 requested a review from chungen0126 July 13, 2026 11:51
@henrybear327
henrybear327 force-pushed the HDDS-15084-core-runtime branch from 95409e3 to f28f384 Compare July 13, 2026 12:12
@henrybear327
henrybear327 force-pushed the HDDS-15084-core-runtime branch from f28f384 to 102c176 Compare July 13, 2026 20:06

@chungen0126 chungen0126 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@peterxcli peterxcli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henrybear327 thanks for the further update! LGTM +1!
pending ci

@peterxcli
peterxcli merged commit ff5d032 into apache:master Jul 13, 2026
45 checks passed
@peterxcli

Copy link
Copy Markdown
Member

Thanks @henrybear327 for the patch, @henrybear327 for the review!

@henrybear327
henrybear327 deleted the HDDS-15084-core-runtime branch July 14, 2026 11:32
@henrybear327

Copy link
Copy Markdown
Contributor Author

Thanks @henrybear327 for the patch, @henrybear327 for the review!

I guess it's thanks @peterxcli and @chungen0126 for the review!

Get some rest :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ozone-local HDDS-14893

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants