HDDS-15146. Remove getDatanodeInfo(DatanodeDetails) from NodeManager

[navinko]

What changes were proposed in this pull request?

Remove getDatanodeInfo(DatanodeDetails) from NodeManager

Please describe your PR in detail:

Rebase 10169.patch from #10169
Fixed test cases
Addressed previous PR review comments

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-15146

How was this patch tested?

Successful CI: https://github.com/navinko/ozone/actions/runs/28108830629
Validated changes post rebase and conflict resoluion with docker run
HDDS-15146-docker-run.txt

[adoroszlai]

Thanks @navinko for working on this.

Whoever merges this, please make sure to add Co-authored-by: Tsz-Wo Nicholas Sze <szetszwo@apache.org> to reflect initial work from #10169.

[szetszwo]

@navinko , thanks a lot for continuing this work!

+1 the change looks good.

[adoroszlai]

Thanks @navinko, @szetszwo for the patch.

Whoever merges this, please make sure to add Co-authored-by: Tsz-Wo Nicholas Sze <szetszwo@apache.org> to reflect initial work from #10169.

I'm sorry, I forgot my own comment.

[adoroszlai]

And it had to be reverted due to code added in other commits on master in the meantime, there was a compile error.

[ERROR] COMPILATION ERROR : 
[ERROR] /home/runner/work/ozone/ozone/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java:[1086,29] cannot find symbol
[ERROR] /home/runner/work/ozone/ozone/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java:[1096,29] cannot find symbol
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.15.0:compile (default-compile) on project hdds-server-scm: Compilation failure: Compilation failure: 
[ERROR] /home/runner/work/ozone/ozone/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java:[1086,29] cannot find symbol
[ERROR]   symbol:   method getDatanodeInfo(org.apache.hadoop.hdds.protocol.DatanodeDetails)
[ERROR]   location: class org.apache.hadoop.hdds.scm.node.SCMNodeManager
[ERROR] /home/runner/work/ozone/ozone/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java:[1096,29] cannot find symbol
[ERROR]   symbol:   method getDatanodeInfo(org.apache.hadoop.hdds.protocol.DatanodeDetails)
[ERROR]   location: class org.apache.hadoop.hdds.scm.node.SCMNodeManager

[adoroszlai]

I've locally fixed both the compile error (was simple) and the commit message. Will push to master after running it through CI in my fork.

https://github.com/adoroszlai/ozone/actions/runs/28259520076

[navinko]

Thanks a lot @adoroszlai @szetszwo for reviewing , merging and fixing quickly the compilation issues. Kindly feel free to assign any new jira.