HDDS-15730. Support more StatefulService types in DBScanner#10654
Open
adoroszlai wants to merge 4 commits into
Open
HDDS-15730. Support more StatefulService types in DBScanner#10654adoroszlai wants to merge 4 commits into
adoroszlai wants to merge 4 commits into
Conversation
Contributor
sreejasahithi
left a comment
Contributor
There was a problem hiding this comment.
Thanks @adoroszlai for the PR.
Comment on lines
+58
to
+60
| public static final StatefulServiceDefinition<DeletedBlocksTransaction> SERVICE_DEFINITION = | ||
| new StatefulServiceDefinition<>(SERVICE_NAME, DeletedBlocksTransaction.parser()); | ||
|
|
Contributor
There was a problem hiding this comment.
SERVICE_DEFINITION here should use DeletedBlocksTransactionSummary, not DeletedBlocksTransaction:
Suggested change
| public static final StatefulServiceDefinition<DeletedBlocksTransaction> SERVICE_DEFINITION = | |
| new StatefulServiceDefinition<>(SERVICE_NAME, DeletedBlocksTransaction.parser()); | |
| public static final StatefulServiceDefinition<DeletedBlocksTransactionSummary> SERVICE_DEFINITION = | |
| new StatefulServiceDefinition<>(SERVICE_NAME, DeletedBlocksTransactionSummary.parser()); |
The old DBScanner also parsed it as DeletedBlocksTransactionSummary.
Contributor
Author
There was a problem hiding this comment.
Thanks for spotting this. The other two definitions are used with subclasses of StatefulService, which ensures type safety. I don't know why this one is different, but now made some further change: use the definition in loadDeletedBlocksSummary(), which returns DeletedBlocksTransactionSummary, so that type mismatch is caught at compile time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor SCM
StatefulServiceto allow using its static metadata (name, parser) without instantiating the service or duplicating code inDBScanner.Add support for Container Balancer and Root CA Rotation Manager services in
DBScanner.https://issues.apache.org/jira/browse/HDDS-15730
How was this patch tested?
https://github.com/adoroszlai/ozone/actions/runs/28643243287