HDDS-15766. Make Recon OM DB large tarball transfer reliable#10696
Open
devmadhuu wants to merge 5 commits into
Open
HDDS-15766. Make Recon OM DB large tarball transfer reliable#10696devmadhuu wants to merge 5 commits into
devmadhuu wants to merge 5 commits into
Conversation
added 2 commits
July 9, 2026 11:20
- TestReconRDBSnapshotProvider: guard File.list() results with requireNonNull. - OzoneManagerServiceProviderImpl: make omSnapshotDBParentDir a local variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Problem:
Recon keeps its own copy of the OM DB and syncs it two ways: incremental delta updates (
getDBUpdates) for the normal case, and a full OM DB snapshot download as the fallback when delta sync cannot be used (Recon fell too far behind, OM no longer has the requested updates, etc.).The full-snapshot fallback was the weak part:
/dbCheckpointcall that streamed the entire OM DB as one tar.On large clusters the OM DB is big, so this approach was slow and fragile.
Approach: Instead of maintaining Recon's own download logic, Recon now reuses the same incremental bootstrap mechanism an OM follower uses to catch up from the OM leader:
/v2/dbCheckpointrequest that carries atoExcludeList[]of SST files the caller already has.On top of the follower behavior, Recon seeds the exclude list from its own currently-installed (live) OM DB before the download starts. RocksDB SST file numbers are content-stable within a DB lineage, so a
000123.sstRecon already has is byte-identical to the leader's. Those SSTs are hard-linked into the candidate dir and advertised in the exclude list, so even a "full" snapshot only transfers the SST files that actually changed. The assembled DB is always complete and correct — a full snapshot still triggers a full task reprocess in Recon, exactly as before; only the bytes on the wire go down.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15766
How was this patch tested?
Testing:
TestReconRDBSnapshotProviderTestOzoneManagerServiceProviderImpl— drives the new provider path for success and failure cases.TestReconWithOzoneManager.testOmDBSyncWithSeqNumberMismatchprovides end-to-end coverage of the full-snapshot fallback against a mini-clusterTestReconWithOzoneManagerHAupdated to drop the stale v1-URL assertion, keeping its end-to-end leader-sync verification.